Bug 143850 - Add assertions to make sure ActiveDOMObject::suspend() / resume() / stop() overrides don't fire events
Summary: Add assertions to make sure ActiveDOMObject::suspend() / resume() / stop() ov...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-16 15:40 PDT by Chris Dumez
Modified: 2015-04-16 16:42 PDT (History)
4 users (show)

See Also:

Attachments
Patch (5.17 KB, patch)
2015-04-16 15:43 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2015-04-16 15:40:15 PDT 
Add assertions to make sure ActiveDOMObject::suspend() / resume() / stop() overrides don't fire events as this is not allowed. This would cause arbitrary JS execution which would be very dangerous in these stages.
Comment 1 Chris Dumez 2015-04-16 15:43:03 PDT 
Created attachment 250957 [details]
Patch
Comment 2 Chris Dumez 2015-04-16 15:48:31 PDT 
I verified locally these assertions are not hit by the current layout tests.
Comment 3 Alexey Proskuryakov 2015-04-16 15:53:02 PDT 
Comment on attachment 250957 [details]
Patch

Seems reasonable.
Comment 4 WebKit Commit Bot 2015-04-16 16:42:43 PDT 
Comment on attachment 250957 [details]
Patch

Clearing flags on attachment: 250957

Committed r182923: <http://trac.webkit.org/changeset/182923>
Comment 5 WebKit Commit Bot 2015-04-16 16:42:48 PDT 
All reviewed patches have been landed.  Closing bug.