Bug 143838 - [ES6] Use specific functions for @@iterator functions
Summary: [ES6] Use specific functions for @@iterator functions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-16 12:27 PDT by Yusuke Suzuki
Modified: 2015-04-16 14:36 PDT (History)
4 users (show)

See Also:

Attachments
Patch (56.73 KB, patch)
2015-04-16 12:40 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (57.12 KB, patch)
2015-04-16 13:15 PDT, Yusuke Suzuki 		ggaren: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2015-04-16 12:27:23 PDT 
In ES6, some functions are used as the method with the different names.

For example,

Map.protoytpe[Symbol.iterator] === Map.prototype.entries
Set.protoytpe[Symbol.iterator] === Set.prototype.values
Array.protoytpe[Symbol.iterator] === Array.prototype.values
%Arguments%[Symbol.iterator] === Array.prototype.values

And we dropp Arguments' iterator implementation and its method for @@iterator since now they use Array Iterator and Array.protoype.values.
Comment 1 Yusuke Suzuki 2015-04-16 12:40:36 PDT 
Created attachment 250940 [details]
Patch
Comment 2 Yusuke Suzuki 2015-04-16 13:15:29 PDT 
Created attachment 250945 [details]
Patch
Comment 3 Geoffrey Garen 2015-04-16 13:23:16 PDT 
Comment on attachment 250945 [details]
Patch

r=me
Comment 4 Yusuke Suzuki 2015-04-16 14:36:36 PDT 
Committed r182911: <http://trac.webkit.org/changeset/182911>