Bug 143816 – Minor AudioContext cleanup

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Audio

[Alexey Proskuryakov]

A few things that I noticed while looking at AudioContext.

[Alexey Proskuryakov]

Created attachment 250905 [details]
proposed patch

[WebKit Commit Bot]

Attachment 250905 [details] did not pass style-queue:


ERROR: Source/WebCore/Modules/webaudio/AudioContext.cpp:194:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/WebCore/Modules/webaudio/AudioContext.cpp:195:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
ERROR: Source/WebCore/Modules/webaudio/AudioContext.cpp:198:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
Total errors found: 3 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Jer Noble]

(In reply to comment #2)
> Attachment 250905 [details] did not pass style-queue:
> 
> 
> ERROR: Source/WebCore/Modules/webaudio/AudioContext.cpp:194:  Should be
> indented on a separate line, with the colon or comma first on that line. 
> [whitespace/indent] [4]


This looks like webkit-style is confused by the FIXME line here. It should probably be of the format: "// FIXME(105870): This assertion fails on tests sometimes", and maybe be on the previous line.  But the error message here seems to just be a bug in check-webkit-style.

[WebKit Commit Bot]

Comment on attachment 250905 [details]
proposed patch

Clearing flags on attachment: 250905

Committed r182889: <http://trac.webkit.org/changeset/182889>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.