Bug 143816 - Minor AudioContext cleanup
Summary: Minor AudioContext cleanup
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Audio (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-15 23:49 PDT by Alexey Proskuryakov
Modified: 2015-04-16 09:20 PDT (History)
3 users (show)

See Also:


Attachments
proposed patch (8.63 KB, patch)
2015-04-15 23:52 PDT, Alexey Proskuryakov
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2015-04-15 23:49:08 PDT
A few things that I noticed while looking at AudioContext.
Comment 1 Alexey Proskuryakov 2015-04-15 23:52:44 PDT
Created attachment 250905 [details]
proposed patch
Comment 2 WebKit Commit Bot 2015-04-15 23:54:26 PDT
Attachment 250905 [details] did not pass style-queue:


ERROR: Source/WebCore/Modules/webaudio/AudioContext.cpp:194:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/WebCore/Modules/webaudio/AudioContext.cpp:195:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
ERROR: Source/WebCore/Modules/webaudio/AudioContext.cpp:198:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
Total errors found: 3 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Jer Noble 2015-04-16 08:35:11 PDT
(In reply to comment #2)
> Attachment 250905 [details] did not pass style-queue:
> 
> 
> ERROR: Source/WebCore/Modules/webaudio/AudioContext.cpp:194:  Should be
> indented on a separate line, with the colon or comma first on that line. 
> [whitespace/indent] [4]


This looks like webkit-style is confused by the FIXME line here. It should probably be of the format: "// FIXME(105870): This assertion fails on tests sometimes", and maybe be on the previous line.  But the error message here seems to just be a bug in check-webkit-style.
Comment 4 WebKit Commit Bot 2015-04-16 09:20:12 PDT
Comment on attachment 250905 [details]
proposed patch

Clearing flags on attachment: 250905

Committed r182889: <http://trac.webkit.org/changeset/182889>
Comment 5 WebKit Commit Bot 2015-04-16 09:20:16 PDT
All reviewed patches have been landed.  Closing bug.