Bug 143695 - Two flaky tests in http/tests/security/mixedContent
Summary: Two flaky tests in http/tests/security/mixedContent
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-13 22:22 PDT by Alexey Proskuryakov
Modified: 2015-04-15 15:26 PDT (History)
2 users (show)

See Also:


Attachments
speculative fix (3.79 KB, patch)
2015-04-13 22:24 PDT, Alexey Proskuryakov
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2015-04-13 22:22:01 PDT
These tests frequently fail with a different order of load events, especially on slower bots:

http/tests/security/mixedContent/data-url-iframe-in-main-frame.html
http/tests/security/mixedContent/insecure-css-in-main-frame.html
Comment 1 Alexey Proskuryakov 2015-04-13 22:24:20 PDT
Created attachment 250692 [details]
speculative fix
Comment 2 Csaba Osztrogonác 2015-04-14 02:55:38 PDT
Comment on attachment 250692 [details]
speculative fix

Looks reasonable, let's see if it fixes the flakiness.
Comment 3 WebKit Commit Bot 2015-04-14 10:31:44 PDT
Comment on attachment 250692 [details]
speculative fix

Clearing flags on attachment: 250692

Committed r182800: <http://trac.webkit.org/changeset/182800>
Comment 4 WebKit Commit Bot 2015-04-14 10:31:47 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Alexey Proskuryakov 2015-04-15 15:25:39 PDT
It did, but I noticed that there are more tests with exactly the same issue. Will file a new bug.