Bug 143646 - build.webkit.org/dashboard: Crash-only queues should show failure when failure limit is exceeded
Summary: build.webkit.org/dashboard: Crash-only queues should show failure when failur...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-12 11:06 PDT by Alexey Proskuryakov
Modified: 2015-04-12 13:05 PDT (History)
2 users (show)

See Also:

Attachments
proposed fix (2.27 KB, patch)
2015-04-12 11:10 PDT, Alexey Proskuryakov 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2015-04-12 11:06:59 PDT 
When there are too many failures on crash-only queues (e.g. 50 timeouts), they remain green, because there are no crashes. This is clearly wrong, the queue is in a broken state, and we need to know about it.
Comment 1 Alexey Proskuryakov 2015-04-12 11:10:07 PDT 
Created attachment 250613 [details]
proposed fix
Comment 2 David Kilzer (:ddkilzer) 2015-04-12 12:18:34 PDT 
Comment on attachment 250613 [details]
proposed fix

r=me
Comment 3 WebKit Commit Bot 2015-04-12 13:05:44 PDT 
Comment on attachment 250613 [details]
proposed fix

Clearing flags on attachment: 250613

Committed r182670: <http://trac.webkit.org/changeset/182670>
Comment 4 WebKit Commit Bot 2015-04-12 13:05:47 PDT 
All reviewed patches have been landed.  Closing bug.