Bug 143639 - editing/spelling/spelling-marker-description.html times out on Mac
Summary: editing/spelling/spelling-marker-description.html times out on Mac
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-11 19:18 PDT by Alexey Proskuryakov
Modified: 2015-04-11 22:13 PDT (History)
3 users (show)

See Also:


Attachments
proposed fix (4.25 KB, patch)
2015-04-11 19:21 PDT, Alexey Proskuryakov
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2015-04-11 19:18:34 PDT
This test has some issues:

1. It expects "wellcome" to be a spelling error, which it is not always.
 1a. The Multilingual spellchecker that we use may allow this spelling.
 1b. If the spellchecker doesn't allow the spelling, then we end up performing an autocorrection instead, because of our NSTestCorrectionDictionary user default content.

2. It expects spelling errors to contain a suggested replacement string, which they do not.

This test is marked as failing or skipped on all existing platforms.
Comment 1 Alexey Proskuryakov 2015-04-11 19:21:00 PDT
Created attachment 250592 [details]
proposed fix
Comment 2 WebKit Commit Bot 2015-04-11 22:13:39 PDT
Comment on attachment 250592 [details]
proposed fix

Clearing flags on attachment: 250592

Committed r182667: <http://trac.webkit.org/changeset/182667>
Comment 3 WebKit Commit Bot 2015-04-11 22:13:44 PDT
All reviewed patches have been landed.  Closing bug.