Bug 143541 - Fix -Wformat in AnimationBase.cpp
Summary: Fix -Wformat in AnimationBase.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Minor
Assignee: Michael Catanzaro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-08 17:06 PDT by Michael Catanzaro
Modified: 2015-04-08 19:16 PDT (History)
6 users (show)

See Also:


Attachments
Patch (3.34 KB, patch)
2015-04-08 18:15 PDT, Michael Catanzaro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2015-04-08 17:06:37 PDT
Since r170070:

../../Source/WebCore/page/animation/AnimationBase.cpp:321:259: warning: format ‘%d’ expects argument of type ‘int’, but argument 5 has type ‘WebCore::AnimationBase::AnimationStateInput’ [-Wformat=]

This only occurs in debug builds.

We can either static_cast it to an int, or print it as a string.
Comment 1 Michael Catanzaro 2015-04-08 18:15:16 PDT
Created attachment 250399 [details]
Patch
Comment 2 WebKit Commit Bot 2015-04-08 19:16:32 PDT
Comment on attachment 250399 [details]
Patch

Clearing flags on attachment: 250399

Committed r182580: <http://trac.webkit.org/changeset/182580>
Comment 3 WebKit Commit Bot 2015-04-08 19:16:37 PDT
All reviewed patches have been landed.  Closing bug.