Bug 143496 - Constant folding of typed array properties should be handled by AI rather than strength reduction
Summary: Constant folding of typed array properties should be handled by AI rather tha...
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
Depends on:
Blocks: 143232
  Show dependency treegraph
Reported: 2015-04-07 13:47 PDT by Filip Pizlo
Modified: 2015-04-08 17:37 PDT (History)
13 users (show)

See Also:

the patch (24.66 KB, patch)
2015-04-07 13:51 PDT, Filip Pizlo
ggaren: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2015-04-07 13:47:00 PDT
Patch forthcoming.
Comment 1 Filip Pizlo 2015-04-07 13:51:45 PDT
Created attachment 250295 [details]
the patch
Comment 2 WebKit Commit Bot 2015-04-07 13:55:04 PDT
Attachment 250295 [details] did not pass style-queue:

ERROR: Source/JavaScriptCore/dfg/DFGGraph.h:696:  The parameter name "arrayMode" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 11 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Geoffrey Garen 2015-04-07 13:58:12 PDT
Comment on attachment 250295 [details]
the patch

Comment 4 Filip Pizlo 2015-04-07 15:10:39 PDT
Landed in http://trac.webkit.org/changeset/182498
Comment 5 Brent Fulgham 2015-04-08 17:37:56 PDT
This change might have broken Web Inspector on Windows.

See <https://bugs.webkit.org/show_bug.cgi?id=143542>.