Bug 143444 - Combine ActionMenuHitTestResult with WebHitTestResult
Summary: Combine ActionMenuHitTestResult with WebHitTestResult
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-06 10:50 PDT by Brady Eidson
Modified: 2015-04-06 15:34 PDT (History)
3 users (show)

See Also:

Attachments
Patch v1 (60.17 KB, patch)
2015-04-06 11:11 PDT, Brady Eidson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2015-04-06 10:50:03 PDT 
Combine ActionMenuHitTestResult with WebHitTestResult

It really doesn't need to be separate.

For example, all of the additional info it stores can be (and will soon be) relevant for normal context menu operations.
Comment 1 Brady Eidson 2015-04-06 11:11:15 PDT 
Created attachment 250210 [details]
Patch v1
Comment 2 WebKit Commit Bot 2015-04-06 11:13:52 PDT 
Attachment 250210 [details] did not pass style-queue:


ERROR: Source/WebKit2/Shared/mac/WebHitTestResult.mm:81:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/Shared/mac/WebHitTestResult.mm:81:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 2 in 18 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 WebKit Commit Bot 2015-04-06 15:34:51 PDT 
Comment on attachment 250210 [details]
Patch v1

Clearing flags on attachment: 250210

Committed r182442: <http://trac.webkit.org/changeset/182442>
Comment 4 WebKit Commit Bot 2015-04-06 15:34:54 PDT 
All reviewed patches have been landed.  Closing bug.