Bug 143295 - [CMake] Make gtest/CMakeLists.txt more readable
Summary: [CMake] Make gtest/CMakeLists.txt more readable
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-03-31 23:52 PDT by Gyuyoung Kim
Modified: 2015-04-01 03:38 PDT (History)
2 users (show)

See Also:

Attachments
Patch (2.06 KB, patch)
2015-03-31 23:52 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Patch (2.06 KB, patch)
2015-03-31 23:54 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2015-03-31 23:52:11 PDT 
gtest/CMakeLists.txt has used add_library() and include_directory() directly. It seems to me that it is unsorted use.
Comment 1 Gyuyoung Kim 2015-03-31 23:52:56 PDT 
Created attachment 249898 [details]
Patch
Comment 2 Gyuyoung Kim 2015-03-31 23:54:05 PDT 
Created attachment 249899 [details]
Patch
Comment 3 WebKit Commit Bot 2015-04-01 03:38:55 PDT 
Comment on attachment 249899 [details]
Patch

Clearing flags on attachment: 249899

Committed r182228: <http://trac.webkit.org/changeset/182228>
Comment 4 WebKit Commit Bot 2015-04-01 03:38:59 PDT 
All reviewed patches have been landed.  Closing bug.