Bug 143259 - [iOS] Rotating PDF in Safari scrolls to the wrong position
Summary: [iOS] Rotating PDF in Safari scrolls to the wrong position
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-03-31 03:53 PDT by Tim Horton
Modified: 2015-03-31 13:51 PDT (History)
4 users (show)

See Also:

Attachments
Patch (2.53 KB, patch)
2015-03-31 03:53 PDT, Tim Horton 		mitz: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2015-03-31 03:53:03 PDT 
[iOS] Rotating PDF in Safari scrolls to the wrong position
Comment 1 Tim Horton 2015-03-31 03:53:31 PDT 
Created attachment 249816 [details]
Patch
Comment 2 mitz 2015-03-31 07:32:45 PDT 
<rdar://problem/19872693>
Comment 3 mitz 2015-03-31 07:35:14 PDT 
Comment on attachment 249816 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=249816&action=review

> Source/WebKit2/UIProcess/ios/WKPDFView.mm:177
> +    CGFloat oldDocumentLeftPercentage = 0;
> +    CGFloat oldDocumentTopPercentage = 0;

These are clearly not percentages. They are fractions.
Comment 4 Tim Horton 2015-03-31 13:51:11 PDT 
http://trac.webkit.org/changeset/182202