Bug 143208 - Web Inspector: Regression: Preview for [[null]] shouldn't be []
Summary: Web Inspector: Regression: Preview for [[null]] shouldn't be []
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-03-29 21:32 PDT by Nikita Vasilyev
Modified: 2015-03-30 15:44 PDT (History)
8 users (show)

See Also:

Attachments
Screenshot of the bug (7.19 KB, image/png)
2015-03-29 21:32 PDT, Nikita Vasilyev 		no flags Details
[PATCH] Proposed Fix (4.83 KB, patch)
2015-03-30 14:36 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nikita Vasilyev 2015-03-29 21:32:20 PDT 
Created attachment 249709 [details]
Screenshot of the bug

An array of arrays with null(s) displayed as an empty array.
Comment 1 Radar WebKit Bug Importer 2015-03-29 21:32:38 PDT 
<rdar://problem/20341961>
Comment 2 Joseph Pecoraro 2015-03-30 11:19:10 PDT 
I bet that InjectedScriptSource _isPreviewableObjectInternal just has to handle null!
Comment 3 Joseph Pecoraro 2015-03-30 14:36:16 PDT 
Created attachment 249764 [details]
[PATCH] Proposed Fix
Comment 4 Mark Lam 2015-03-30 14:52:51 PDT 
Comment on attachment 249764 [details]
[PATCH] Proposed Fix

r=me
Comment 5 WebKit Commit Bot 2015-03-30 15:44:14 PDT 
Comment on attachment 249764 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 249764

Committed r182156: <http://trac.webkit.org/changeset/182156>
Comment 6 WebKit Commit Bot 2015-03-30 15:44:19 PDT 
All reviewed patches have been landed.  Closing bug.