Bug 143190 - [iOS] When Web Audio is interrupted by a phone call, it cannot be restarted.
Summary: [iOS] When Web Audio is interrupted by a phone call, it cannot be restarted.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-03-28 23:31 PDT by Jer Noble
Modified: 2015-04-27 14:23 PDT (History)
2 users (show)

See Also:

Attachments
Patch (62.47 KB, patch)
2015-03-29 08:03 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch (62.39 KB, patch)
2015-03-29 08:13 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch (62.77 KB, patch)
2015-03-29 08:32 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch (63.45 KB, patch)
2015-03-29 11:55 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch (63.50 KB, patch)
2015-03-29 13:55 PDT, Jer Noble 		darin: review+
Details | Formatted Diff | Diff
Patch for landing (63.47 KB, patch)
2015-03-29 17:13 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2015-03-28 23:31:17 PDT 
[iOS] When Web Audio is interrupted by a phone call, it cannot be restarted.
Comment 1 Jer Noble 2015-03-29 08:03:17 PDT 
Created attachment 249682 [details]
Patch
Comment 2 Jer Noble 2015-03-29 08:08:28 PDT 
rdar://problem/16955315
Comment 3 Jer Noble 2015-03-29 08:13:23 PDT 
Created attachment 249683 [details]
Patch
Comment 4 Jer Noble 2015-03-29 08:32:38 PDT 
Created attachment 249684 [details]
Patch
Comment 5 Jer Noble 2015-03-29 11:55:24 PDT 
Created attachment 249686 [details]
Patch
Comment 6 Jer Noble 2015-03-29 13:55:21 PDT 
Created attachment 249698 [details]
Patch
Comment 7 Darin Adler 2015-03-29 16:34:42 PDT 
Comment on attachment 249698 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=249698&action=review

> Source/WebCore/Modules/webaudio/AudioContext.h:348
> +    bool m_isDeletionScheduled = { false };
> +    bool m_isStopScheduled = { false };
> +    bool m_isInitialized = { false };
> +    bool m_isAudioThreadFinished = { false };
> +    bool m_automaticPullNodesNeedUpdating = { false };
> +    bool m_isOfflineContext = { false };

I don’t think you need the "="; in fact I didn’t even know you could include them.
Comment 8 Jer Noble 2015-03-29 17:07:39 PDT 
Comment on attachment 249698 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=249698&action=review

>> Source/WebCore/Modules/webaudio/AudioContext.h:348
>> +    bool m_isOfflineContext = { false };
> 
> I don’t think you need the "="; in fact I didn’t even know you could include them.

After a little sleuthing, it looks like C++11 both added the `type name { value }` syntax, and also loosened the requirements for the `type name = value` syntax, allowing it for non-const, non-static members.  Still, I'll switch these all to the former syntax.
Comment 9 Jer Noble 2015-03-29 17:13:07 PDT 
Created attachment 249704 [details]
Patch for landing
Comment 10 WebKit Commit Bot 2015-03-30 09:15:48 PDT 
Comment on attachment 249704 [details]
Patch for landing

Clearing flags on attachment: 249704

Committed r182141: <http://trac.webkit.org/changeset/182141>