Bug 142921 - DFG IR should represent the various of effects of put_by_id in a single node
Summary: DFG IR should represent the various of effects of put_by_id in a single node
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 142920
Blocks:
  Show dependency tree / graph
 
Reported: 2015-03-20 14:20 PDT by Filip Pizlo
Modified: 2015-03-20 15:03 PDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2015-03-20 14:20:09 PDT 
Currently put_by_id may turn into a three-node lowering: AllocatePropertyStorage, PutByOffset, PutStructure.  This barely works.  We should use a single node ("PutByOffsetWithPropertyAllocationTransition", or something with a shorter name) so that code motion of things that GC and exit doesn't have to tiptoe around this.
Comment 1 Filip Pizlo 2015-03-20 15:03:37 PDT 
An alternate approach might be: https://bugs.webkit.org/show_bug.cgi?id=142924