Bug 142907 - [EFL][GTK] WebKit2's generate-forwarding-headers.pl runs too many times
Summary: [EFL][GTK] WebKit2's generate-forwarding-headers.pl runs too many times
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Csaba Osztrogonác
URL:
Keywords:
Depends on: 142909
Blocks:
  Show dependency treegraph
 
Reported: 2015-03-20 05:22 PDT by Csaba Osztrogonác
Modified: 2015-04-09 10:02 PDT (History)
6 users (show)

See Also:


Attachments
Patch (9.57 KB, patch)
2015-03-20 06:24 PDT, Csaba Osztrogonác
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2015-03-20 05:22:11 PDT
generate-forwarding-headers.pl is to generate forwarding headers for 
"Mac framework style"  includes in WebKit2, WTR and WebKitTestAPI.
(for example: #include <WebKit/baz.h> when foo.h is in WebKit2/foo/bar/baz.h)

Now it runs 10 times on EFL, but 3 run would be enough - one for each target.
But to do it, generate-forwarding-headers.pl should be refactored a little bit.

Patch is coming soon.
Comment 1 Zan Dobersek 2015-03-20 05:25:15 PDT
While only slightly related to this bug, I'm interested what people think about the verbosity of this script.

Does anyone else find all the "[Creating forwarding header for ...]" messages during build either terribly helpful or completely unnecessary? I myself would like to remove the message, or at least make it optional in case the script needs to be debugged.
Comment 2 Csaba Osztrogonác 2015-03-20 05:35:20 PDT
(In reply to comment #1)
> While only slightly related to this bug, I'm interested what people think
> about the verbosity of this script.
> 
> Does anyone else find all the "[Creating forwarding header for ...]"
> messages during build either terribly helpful or completely unnecessary? I
> myself would like to remove the message, or at least make it optional in
> case the script needs to be debugged.

I agree, we can disable it by default, here you are: bug142908
Comment 3 Csaba Osztrogonác 2015-03-20 06:24:06 PDT
Created attachment 249111 [details]
Patch

finished, but it depends on bug142907 because of changed  to array
Comment 4 Csaba Osztrogonác 2015-03-20 06:26:32 PDT
(In reply to comment #3)
> Created attachment 249111 [details]
> Patch
> 
> finished, but it depends on bug142907 because of changed  to array

typo: changed $platform to array (but I should have escaped $platform in bash :) )
Comment 5 Csaba Osztrogonác 2015-04-03 03:34:52 PDT
Comment on attachment 249111 [details]
Patch

Ooops, missed to set r? after bug142909 was fixed and EWS passed.
Comment 6 Carlos Garcia Campos 2015-04-09 00:23:22 PDT
Comment on attachment 249111 [details]
Patch

Ok, let's try this way. Thanks!
Comment 7 WebKit Commit Bot 2015-04-09 01:12:48 PDT
Comment on attachment 249111 [details]
Patch

Clearing flags on attachment: 249111

Committed r182595: <http://trac.webkit.org/changeset/182595>
Comment 8 WebKit Commit Bot 2015-04-09 01:12:53 PDT
All reviewed patches have been landed.  Closing bug.
Comment 9 Csaba Osztrogonác 2015-04-09 04:53:33 PDT
and a typo fixed in http://trac.webkit.org/changeset/182598