Bug 142907 – [EFL][GTK] WebKit2's generate-forwarding-headers.pl runs too many times

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Csaba Osztrogonác]

generate-forwarding-headers.pl is to generate forwarding headers for 
"Mac framework style"  includes in WebKit2, WTR and WebKitTestAPI.
(for example: #include <WebKit/baz.h> when foo.h is in WebKit2/foo/bar/baz.h)

Now it runs 10 times on EFL, but 3 run would be enough - one for each target.
But to do it, generate-forwarding-headers.pl should be refactored a little bit.

Patch is coming soon.

[Zan Dobersek]

While only slightly related to this bug, I'm interested what people think about the verbosity of this script.

Does anyone else find all the "[Creating forwarding header for ...]" messages during build either terribly helpful or completely unnecessary? I myself would like to remove the message, or at least make it optional in case the script needs to be debugged.

[Csaba Osztrogonác]

(In reply to comment #1)
> While only slightly related to this bug, I'm interested what people think
> about the verbosity of this script.
> 
> Does anyone else find all the "[Creating forwarding header for ...]"
> messages during build either terribly helpful or completely unnecessary? I
> myself would like to remove the message, or at least make it optional in
> case the script needs to be debugged.

I agree, we can disable it by default, here you are: bug142908

[Csaba Osztrogonác]

Created attachment 249111 [details]
Patch

finished, but it depends on bug142907 because of changed  to array

[Csaba Osztrogonác]

(In reply to comment #3)
> Created attachment 249111 [details]
> Patch
> 
> finished, but it depends on bug142907 because of changed  to array

typo: changed $platform to array (but I should have escaped $platform in bash :) )

[Csaba Osztrogonác]

Comment on attachment 249111 [details]
Patch

Ooops, missed to set r? after bug142909 was fixed and EWS passed.

[Carlos Garcia Campos]

Comment on attachment 249111 [details]
Patch

Ok, let's try this way. Thanks!

[WebKit Commit Bot]

Comment on attachment 249111 [details]
Patch

Clearing flags on attachment: 249111

Committed r182595: <http://trac.webkit.org/changeset/182595>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Csaba Osztrogonác]

and a typo fixed in http://trac.webkit.org/changeset/182598