Bug 142886 - Add support for deleting individual cache entries
Summary: Add support for deleting individual cache entries
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-03-19 17:22 PDT by Anders Carlsson
Modified: 2015-03-19 18:37 PDT (History)
1 user (show)

See Also:


Attachments
Patch (4.04 KB, patch)
2015-03-19 17:26 PDT, Anders Carlsson
koivisto: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2015-03-19 17:22:22 PDT
Add support for deleting individual cache entries
Comment 1 Anders Carlsson 2015-03-19 17:26:40 PDT
Created attachment 249072 [details]
Patch
Comment 2 WebKit Commit Bot 2015-03-19 17:29:37 PDT
Attachment 249072 [details] did not pass style-queue:


ERROR: Source/WebKit2/NetworkProcess/NetworkProcess.cpp:368:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Antti Koivisto 2015-03-19 17:49:34 PDT
Comment on attachment 249072 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=249072&action=review

> Source/WebKit2/NetworkProcess/NetworkProcess.cpp:370
> +static void clearDiskCacheEntries(const Vector<SecurityOriginData>& origins, std::function<void ()> completionHandler)
> +{
> +#if ENABLE(NETWORK_CACHE)

Maybe we should at some point just move this code within the NetworkCache?
Comment 4 Anders Carlsson 2015-03-19 18:37:51 PDT
Committed r181775: <http://trac.webkit.org/changeset/181775>