Bug 142874 - run-jsc-benchmarks should only report preferred mean
Summary: run-jsc-benchmarks should only report preferred mean
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-03-19 13:03 PDT by Ryosuke Niwa
Modified: 2015-03-19 17:54 PDT (History)
4 users (show)

See Also:

Attachments
Fixes the bug (2.34 KB, patch)
2015-03-19 13:05 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2015-03-19 13:03:38 PDT 
Don't report non-preferred means.
Comment 1 Ryosuke Niwa 2015-03-19 13:05:42 PDT 
Created attachment 249052 [details]
Fixes the bug
Comment 2 Geoffrey Garen 2015-03-19 15:19:35 PDT 
Comment on attachment 249052 [details]
Fixes the bug

r=me

Does the output text still specify the name of the mean (harmonic, geometric, arithmetic)? I think it does -- just want to double-check.
Comment 3 Ryosuke Niwa 2015-03-19 15:42:26 PDT 
(In reply to comment #2)
> Comment on attachment 249052 [details]
> Fixes the bug
> 
> r=me
> 
> Does the output text still specify the name of the mean (harmonic,
> geometric, arithmetic)? I think it does -- just want to double-check.

Yes.  It'll be like <artihmetic> just without * since there will be exactly one mean per test.
Comment 4 Ryosuke Niwa 2015-03-19 15:47:31 PDT 
Comment on attachment 249052 [details]
Fixes the bug

Clearing flags on attachment: 249052

Committed r181764: <http://trac.webkit.org/changeset/181764>
Comment 5 Ryosuke Niwa 2015-03-19 15:47:35 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Ryosuke Niwa 2015-03-19 17:54:26 PDT 
Fixed the script in r181774.