Bug 142822 - [Streams API] Update ReadableStream API according new version of the specification
Summary: [Streams API] Update ReadableStream API according new version of the specific...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-03-18 05:29 PDT by youenn fablet
Modified: 2015-03-19 01:28 PDT (History)
3 users (show)

See Also:

Attachments
Patch (14.97 KB, patch)
2015-03-18 05:41 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Trying to fix mac build (15.13 KB, patch)
2015-03-18 06:22 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2015-03-18 05:29:42 PDT 
The latest version of the spec (https://streams.spec.whatwg.org/commit-snapshots/ee2976b593bf4181b2a28719b6a5b6e98632c7d0) splits ReadableStream functionality between ReadableStream (responsible of chunk queue management) and ReadableStreamReader (responsible to give access to chunks).
Removal of state, ready and closed from ReadableStream API should be done, as well as adding getReader.
Comment 1 youenn fablet 2015-03-18 05:41:26 PDT 
Created attachment 248924 [details]
Patch
Comment 2 youenn fablet 2015-03-18 06:22:15 PDT 
Created attachment 248927 [details]
Trying to fix mac build
Comment 3 Benjamin Poulain 2015-03-18 20:42:25 PDT 
Comment on attachment 248927 [details]
Trying to fix mac build

Damn, that's not a small spec change.
Comment 4 WebKit Commit Bot 2015-03-19 01:28:04 PDT 
Comment on attachment 248927 [details]
Trying to fix mac build

Clearing flags on attachment: 248927

Committed r181736: <http://trac.webkit.org/changeset/181736>
Comment 5 WebKit Commit Bot 2015-03-19 01:28:06 PDT 
All reviewed patches have been landed.  Closing bug.