Bug 142761 - [CMake][EFL] Build test tools only for developer mode
Summary: [CMake][EFL] Build test tools only for developer mode
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-03-16 18:50 PDT by Gyuyoung Kim
Modified: 2015-03-17 00:57 PDT (History)
2 users (show)

See Also:

Attachments
Patch (5.10 KB, patch)
2015-03-16 18:52 PDT, Gyuyoung Kim 		ossy: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2015-03-16 18:50:53 PDT 
Do not build EFL MiniBrowser, WebKitTestRunner, and ImageDiff on release mode.
Comment 1 Gyuyoung Kim 2015-03-16 18:52:01 PDT 
Created attachment 248777 [details]
Patch
Comment 2 Csaba Osztrogonác 2015-03-17 00:35:01 PDT 
Comment on attachment 248777 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=248777&action=review

LGTM

> Tools/ChangeLog:8
> +        Do not build EFL MiniBrowser, WebKitTestRunner, and ImageDiff on release mode.

Using release mode is a little bit confusing here, I prefer production mode for non-developer build.

> ChangeLog:8
> +        Do not build EFL MiniBrowser, WebKitTestRunner, and ImageDiff on release mode.

ditto
Comment 3 Gyuyoung Kim 2015-03-17 00:56:15 PDT 
Committed r181621: <http://trac.webkit.org/changeset/181621>
Comment 4 Gyuyoung Kim 2015-03-17 00:57:12 PDT 
(In reply to comment #2)
> Comment on attachment 248777 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=248777&action=review
> 
> LGTM
> 
> > Tools/ChangeLog:8
> > +        Do not build EFL MiniBrowser, WebKitTestRunner, and ImageDiff on release mode.
> 
> Using release mode is a little bit confusing here, I prefer production mode
> for non-developer build.
> 
> > ChangeLog:8
> > +        Do not build EFL MiniBrowser, WebKitTestRunner, and ImageDiff on release mode.
> 
> ditto

Ok, I land this patch after fixing it.