Bug 142648 - RenderBlock::imageChange() calling const methods on exit
Summary: RenderBlock::imageChange() calling const methods on exit
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-03-12 17:22 PDT by Adenilson Cavalcanti Silva
Modified: 2015-03-14 13:50 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.29 KB, patch)
2015-03-12 17:24 PDT, Adenilson Cavalcanti 		no flags Details | Formatted Diff | Diff
Patch (2.15 KB, patch)
2015-03-12 20:55 PDT, Adenilson Cavalcanti 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adenilson Cavalcanti Silva 2015-03-12 17:22:55 PDT 
Remove call to const methods at function exit.
Comment 1 Adenilson Cavalcanti 2015-03-12 17:24:23 PDT 
Created attachment 248556 [details]
Patch
Comment 2 Darin Adler 2015-03-12 17:50:05 PDT 
Comment on attachment 248556 [details]
Patch

I suggest remove this override entirely.
Comment 3 Adenilson Cavalcanti Silva 2015-03-12 20:35:17 PDT 
Yeah, makes sense. I will upload a new patch doing that.
Comment 4 Adenilson Cavalcanti 2015-03-12 20:55:57 PDT 
Created attachment 248565 [details]
Patch
Comment 5 Brent Fulgham 2015-03-14 13:04:46 PDT 
Comment on attachment 248565 [details]
Patch

r=me.
Comment 6 WebKit Commit Bot 2015-03-14 13:50:23 PDT 
Comment on attachment 248565 [details]
Patch

Clearing flags on attachment: 248565

Committed r181500: <http://trac.webkit.org/changeset/181500>
Comment 7 WebKit Commit Bot 2015-03-14 13:50:27 PDT 
All reviewed patches have been landed.  Closing bug.