Bug 142606 - Broke updating media element time following r181279
Summary: Broke updating media element time following r181279
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2015-03-11 18:12 PDT by Roger Fong
Modified: 2015-03-11 22:01 PDT (History)
3 users (show)

See Also:

patch (1.33 KB, patch)
2015-03-11 18:18 PDT, Roger Fong
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Roger Fong 2015-03-11 18:12:11 PDT
Following http://trac.webkit.org/changeset/181279 I broke updating time while scrubbing.

The reason is that before we were blanket updating the whole control panel anytime the mouse moved.

I changed it such that it only updated as a result of a mouse move if the controls were hidden (to unhide them)
However I didn’t quite think it through enough and forgot that we also need to update the times of the control display as a result of a mouse move if we are scrubbing.
Comment 1 Roger Fong 2015-03-11 18:14:42 PDT
Comment 2 Roger Fong 2015-03-11 18:18:04 PDT
Created attachment 248474 [details]
Comment 3 WebKit Commit Bot 2015-03-11 22:01:30 PDT
Comment on attachment 248474 [details]

Clearing flags on attachment: 248474

Committed r181428: <http://trac.webkit.org/changeset/181428>
Comment 4 WebKit Commit Bot 2015-03-11 22:01:33 PDT
All reviewed patches have been landed.  Closing bug.