Bug 142598 - REGRESSION(r179340): Caused images to stay alive forever when navigating away from the page before they finish loading. (Requested by kling on #webkit).
Summary: REGRESSION(r179340): Caused images to stay alive forever when navigating away...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: WebKit Commit Bot
URL:
Keywords:
Depends on:
Blocks: 140722
  Show dependency tree / graph
 
Reported: 2015-03-11 15:46 PDT by WebKit Commit Bot
Modified: 2015-03-11 17:50 PDT (History)
3 users (show)

See Also:

Attachments
ROLLOUT of r179340 (9.43 KB, patch)
2015-03-11 15:46 PDT, WebKit Commit Bot 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description WebKit Commit Bot 2015-03-11 15:46:20 PDT 
http://trac.webkit.org/changeset/179340 broke the build:
Caused images to stay alive forever when navigating away from the page before they finish loading. (Requested by kling on #webkit).

This is an automatic bug report generated by webkitbot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests fail.
Comment 1 WebKit Commit Bot 2015-03-11 15:46:39 PDT 
Created attachment 248458 [details]
ROLLOUT of r179340

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.
Comment 2 Andreas Kling 2015-03-11 15:48:47 PDT 
This caused various problems with ImageLoaders getting stuck with m_hasPendingLoadEvent=true, which prevents the garbage collector from deleting these elements.

I'm rolling the change out since it wasn't clearly fixing a bug in the first place.
Comment 3 WebKit Commit Bot 2015-03-11 15:53:13 PDT 
Comment on attachment 248458 [details]
ROLLOUT of r179340

Clearing flags on attachment: 248458

Committed r181412: <http://trac.webkit.org/changeset/181412>
Comment 4 WebKit Commit Bot 2015-03-11 15:53:17 PDT 
All reviewed patches have been landed.  Closing bug.