Bug 142540 - Stop using USE(CFNETWORK) path on iOS
Summary: Stop using USE(CFNETWORK) path on iOS
Status: REOPENED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords:
Depends on:
Blocks: 137936
  Show dependency treegraph
 
Reported: 2015-03-10 12:33 PDT by Antti Koivisto
Modified: 2016-01-14 15:15 PST (History)
15 users (show)

See Also:


Attachments
patch (12.82 KB, patch)
2015-03-10 12:37 PDT, Antti Koivisto
no flags Details | Formatted Diff | Diff
patch (12.87 KB, patch)
2015-03-10 13:45 PDT, Antti Koivisto
no flags Details | Formatted Diff | Diff
Rebaseline Antti's 2015-03-10 patch and merge various fixes from Bug 137936 (30.28 KB, patch)
2015-12-30 11:15 PST, David Kilzer (:ddkilzer)
no flags Details | Formatted Diff | Diff
Fix all the build failures v1 (30.44 KB, patch)
2015-12-30 15:00 PST, David Kilzer (:ddkilzer)
no flags Details | Formatted Diff | Diff
Fix all the build failures v2 (30.52 KB, patch)
2015-12-30 15:29 PST, David Kilzer (:ddkilzer)
no flags Details | Formatted Diff | Diff
Fix all the build failures v3 (30.52 KB, patch)
2015-12-30 15:52 PST, David Kilzer (:ddkilzer)
no flags Details | Formatted Diff | Diff
Patch v4 (28.39 KB, patch)
2015-12-30 17:47 PST, David Kilzer (:ddkilzer)
no flags Details | Formatted Diff | Diff
Patch v5 (29.37 KB, patch)
2015-12-30 20:36 PST, David Kilzer (:ddkilzer)
no flags Details | Formatted Diff | Diff
Part 2/2: Stop using USE(CFNETWORK) on iOS (1.06 KB, patch)
2016-01-13 16:54 PST, David Kilzer (:ddkilzer)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2015-03-10 12:33:38 PDT
Use the same networking APIs as OS X.
Comment 1 Antti Koivisto 2015-03-10 12:37:31 PDT
Created attachment 248347 [details]
patch
Comment 2 Alexey Proskuryakov 2015-03-10 13:00:07 PDT
My previous comments still apply, I object to doing this now.
Comment 3 Antti Koivisto 2015-03-10 13:45:24 PDT
Created attachment 248352 [details]
patch
Comment 4 David Kilzer (:ddkilzer) 2015-12-30 11:15:23 PST
Created attachment 268009 [details]
Rebaseline Antti's 2015-03-10 patch and merge various fixes from Bug 137936
Comment 5 David Kilzer (:ddkilzer) 2015-12-30 15:00:10 PST
Created attachment 268013 [details]
Fix all the build failures v1
Comment 6 David Kilzer (:ddkilzer) 2015-12-30 15:29:40 PST
Created attachment 268015 [details]
Fix all the build failures v2
Comment 7 David Kilzer (:ddkilzer) 2015-12-30 15:52:44 PST
Created attachment 268020 [details]
Fix all the build failures v3
Comment 8 David Kilzer (:ddkilzer) 2015-12-30 17:47:51 PST
Created attachment 268021 [details]
Patch v4
Comment 9 David Kilzer (:ddkilzer) 2015-12-30 19:14:57 PST
Comment on attachment 268021 [details]
Patch v4

Need to run layout tests locally with iOS Simulator build before landing to make sure nothing is broken, but please review for any issues in the meantime.
Comment 10 David Kilzer (:ddkilzer) 2015-12-30 20:36:42 PST
Created attachment 268024 [details]
Patch v5
Comment 11 Daniel Bates 2015-12-31 08:57:42 PST
Comment on attachment 268024 [details]
Patch v5

Looks sane to me.
Comment 12 David Kilzer (:ddkilzer) 2015-12-31 15:50:46 PST
Committed r194472: <http://trac.webkit.org/changeset/194472>
Comment 13 David Kilzer (:ddkilzer) 2015-12-31 15:54:18 PST
(In reply to comment #12)
> Committed r194472: <http://trac.webkit.org/changeset/194472>

I landed Step 1/2 as all changes for the reviewed patch except actually turning off USE(CFNETWORK) for internal builds.

This should reduce the iOS Simulator WK1 Tests down to less than 10 crashes per run on build.webkit.org.

I will land the Platform.h change after discussing with folks working on WebKit performance.
Comment 14 David Kilzer (:ddkilzer) 2016-01-13 16:54:16 PST
Created attachment 268918 [details]
Part 2/2: Stop using USE(CFNETWORK) on iOS
Comment 15 David Kilzer (:ddkilzer) 2016-01-13 16:55:00 PST
(In reply to comment #13)
> I will land the Platform.h change after discussing with folks working on
> WebKit performance.

I checked with the performance team.  We'll just land this separately, then watch the bots for any regressions.
Comment 16 Chris Dumez 2016-01-13 16:56:13 PST
Comment on attachment 268918 [details]
Part 2/2: Stop using USE(CFNETWORK) on iOS

r=me
Comment 17 WebKit Commit Bot 2016-01-14 04:05:12 PST
Comment on attachment 268918 [details]
Part 2/2: Stop using USE(CFNETWORK) on iOS

Clearing flags on attachment: 268918

Committed r195035: <http://trac.webkit.org/changeset/195035>
Comment 18 WebKit Commit Bot 2016-01-14 04:05:17 PST
All reviewed patches have been landed.  Closing bug.
Comment 19 Chris Dumez 2016-01-14 15:00:38 PST
Reverted r195035 for reason:

Caused 1-3% PLT regression on iOS

Committed r195079: <http://trac.webkit.org/changeset/195079>