Bug 142418 - Add an option to run-webkit-tests to override the LayoutTests/ directory
Summary: Add an option to run-webkit-tests to override the LayoutTests/ directory
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-03-06 16:26 PST by Jer Noble
Modified: 2015-03-09 13:52 PDT (History)
6 users (show)

See Also:

Attachments
Patch (2.76 KB, patch)
2015-03-06 16:30 PST, Jer Noble 		ddkilzer: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2015-03-06 16:26:43 PST 
Add an option to run-webkit-tests to override the LayoutTests/ directory
Comment 1 Jer Noble 2015-03-06 16:30:14 PST 
Created attachment 248111 [details]
Patch
Comment 2 WebKit Commit Bot 2015-03-06 16:32:42 PST 
Attachment 248111 [details] did not pass style-queue:


ERROR: Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:212:  whitespace before ']'  [pep8/E202] [5]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 David Kilzer (:ddkilzer) 2015-03-09 13:39:04 PDT 
Comment on attachment 248111 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=248111&action=review

r=me if you shorten the switch name to just "Tools/Scripts/webkitpy/port/base_unittest.py".

> Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:212
> +        optparse.make_option("--override-layout-tests-directory", action="store", default=None,
> +            help="Override the default layout test directory.", dest="layout_tests_dir")

Let's remove "override-" from "--layout-tests-directory".  You're implicitly overriding it by specifying a different directory, so no need for extra typing.
Comment 4 Jer Noble 2015-03-09 13:52:22 PDT 
Committed r181280: <http://trac.webkit.org/changeset/181280>