Bug 142241 - bmalloc: Don't branch when setting the owner of a large object
Summary: bmalloc: Don't branch when setting the owner of a large object
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Geoffrey Garen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-03-03 16:14 PST by Geoffrey Garen
Modified: 2015-03-03 16:30 PST (History)
1 user (show)

See Also:


Attachments
Patch (1.60 KB, patch)
2015-03-03 16:14 PST, Geoffrey Garen
no flags Details | Formatted Diff | Diff
Patch (1.65 KB, patch)
2015-03-03 16:21 PST, Geoffrey Garen
kling: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Geoffrey Garen 2015-03-03 16:14:20 PST
bmalloc: Don't branch when setting the owner of a large object
Comment 1 Geoffrey Garen 2015-03-03 16:14:41 PST
Created attachment 247806 [details]
Patch
Comment 2 Geoffrey Garen 2015-03-03 16:15:00 PST
Uploading to try to find out why the EFL build failed.
Comment 3 WebKit Commit Bot 2015-03-03 16:17:26 PST
Attachment 247806 [details] did not pass style-queue:


ERROR: Source/bmalloc/bmalloc/BoundaryTag.h:88:  Please declare enum bitfields as unsigned integral types.  [runtime/enum_bitfields] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Geoffrey Garen 2015-03-03 16:21:10 PST
Created attachment 247808 [details]
Patch
Comment 5 Andreas Kling 2015-03-03 16:27:57 PST
Comment on attachment 247808 [details]
Patch

r=me
Comment 6 Geoffrey Garen 2015-03-03 16:30:22 PST
Committed r180964: <http://trac.webkit.org/changeset/180964>