WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
142201
Adopt new API for keyboard interaction
https://bugs.webkit.org/show_bug.cgi?id=142201
Summary
Adopt new API for keyboard interaction
Enrica Casucci
Reported
2015-03-02 17:45:13 PST
rdar://problem/19924949
Attachments
Patch
(2.31 KB, patch)
2015-03-02 17:47 PST
,
Enrica Casucci
no flags
Details
Formatted Diff
Diff
Patch2
(2.25 KB, patch)
2015-03-02 18:15 PST
,
Enrica Casucci
joepeck
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Enrica Casucci
Comment 1
2015-03-02 17:47:23 PST
Created
attachment 247726
[details]
Patch
Enrica Casucci
Comment 2
2015-03-02 18:15:48 PST
Created
attachment 247731
[details]
Patch2 I found a mistake in the previous one.
Joseph Pecoraro
Comment 3
2015-03-02 19:06:50 PST
Comment on
attachment 247731
[details]
Patch2 View in context:
https://bugs.webkit.org/attachment.cgi?id=247731&action=review
r=me
> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:1226 > +#if (__IPHONE_OS_VERSION_MIN_REQUIRED > 80300)
Nit: I think you can drop the parenthesis here.
Enrica Casucci
Comment 4
2015-03-03 09:46:35 PST
Committed revision 180939.
Enrica Casucci
Comment 5
2015-03-03 10:52:41 PST
Fixed typo in platform guard. Committed revision 180943.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug