Bug 142201 - Adopt new API for keyboard interaction
Summary: Adopt new API for keyboard interaction
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified iOS 8.1
: P2 Normal
Assignee: Enrica Casucci
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-03-02 17:45 PST by Enrica Casucci
Modified: 2015-03-03 10:52 PST (History)
0 users

See Also:

Attachments
Patch (2.31 KB, patch)
2015-03-02 17:47 PST, Enrica Casucci 		no flags Details | Formatted Diff | Diff
Patch2 (2.25 KB, patch)
2015-03-02 18:15 PST, Enrica Casucci 		joepeck: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Enrica Casucci 2015-03-02 17:45:13 PST 
rdar://problem/19924949
Comment 1 Enrica Casucci 2015-03-02 17:47:23 PST 
Created attachment 247726 [details]
Patch
Comment 2 Enrica Casucci 2015-03-02 18:15:48 PST 
Created attachment 247731 [details]
Patch2

I found a mistake in the previous one.
Comment 3 Joseph Pecoraro 2015-03-02 19:06:50 PST 
Comment on attachment 247731 [details]
Patch2

View in context: https://bugs.webkit.org/attachment.cgi?id=247731&action=review

r=me

> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:1226
> +#if (__IPHONE_OS_VERSION_MIN_REQUIRED > 80300)

Nit: I think you can drop the parenthesis here.
Comment 4 Enrica Casucci 2015-03-03 09:46:35 PST 
Committed revision 180939.
Comment 5 Enrica Casucci 2015-03-03 10:52:41 PST 
Fixed typo in platform guard.
Committed revision 180943.