Bug 142125 - Web Inspector: Add Context Menus to Object Tree properties
Summary: Web Inspector: Add Context Menus to Object Tree properties
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
Keywords: DoNotImportToRadar
Depends on:
Reported: 2015-02-27 19:55 PST by Joseph Pecoraro
Modified: 2015-03-02 11:33 PST (History)
7 users (show)

See Also:

[PATCH] Proposed Fix (12.08 KB, patch)
2015-02-27 20:00 PST, Joseph Pecoraro
timothy: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2015-02-27 19:55:16 PST
Add Context Menus to Object Tree properties.

Things like:
  - copy path to property
  - jump to function definition
  - reveal node in DOM tree
Comment 1 Joseph Pecoraro 2015-02-27 20:00:31 PST
Created attachment 247584 [details]
[PATCH] Proposed Fix

This avoids context menus on Array indexes. I will have to come up with a better way to share the code between ArrayTreeElement and PropertyTreeElement. I'm thinking of making an ObjectTreeBaseTreeElement for the shared logic.
Comment 2 Timothy Hatcher 2015-02-27 21:03:04 PST
Comment on attachment 247584 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=247584&action=review

> Source/JavaScriptCore/inspector/JSInjectedScriptHost.cpp:169
> +    // FIXME: This should provide better details for JSBoundFunctions.

Comment 3 Timothy Hatcher 2015-02-27 21:03:36 PST
ObjectTreeBaseTreeElement sounds like a good idea.
Comment 4 Joseph Pecoraro 2015-03-02 11:33:57 PST