Bug 142052 – Drop unnecessary DatabaseManager::hasOpenDatabases() in PageCache::canCachePageContainingThisFrame()

• Status: RESOLVED
• Resolution: FIXED
• Component: Page Loading

[Chris Dumez]

Drop unnecessary DatabaseManager::hasOpenDatabases() in PageCache::canCachePageContainingThisFrame(). DatabaseContext is an ActiveDOMObject and DatabaseContext::canSuspend() returns false if its has open databases already. Therefore, such pages would already not go into the page cache.

Another issue is that DatabaseContext::m_hasOpenDatabases is never reset to false. Therefore, any page that ever used the WebDatabase API is currently not page-cacheable. This issue will be addressed separately.

[Chris Dumez]

Actually, DatabaseContext does not even override ActiveDOMObject::canSuspend() currently no it always returns false and any page with a DatabaseContext is not page-cacheable, no matter if there are open databases or not.

[Chris Dumez]

Created attachment 247439 [details]
Patch

[Chris Dumez]

Radar: <rdar://problem/19923085>

[Andreas Kling]

Comment on attachment 247439 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=247439&action=review

r=me

> Source/WebCore/ChangeLog:18
> +        An issue that remains is that DatabaseContext::m_hasOpenDatabases is never reset
> +        to false so once a page opened a database, it will never be page-cacheable. This
> +        will be taken care of separately though.

Sweet.

[WebKit Commit Bot]

Comment on attachment 247439 [details]
Patch

Rejecting attachment 247439 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 247439, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
file Source/WebCore/page/DiagnosticLoggingKeys.cpp
patching file Source/WebCore/page/DiagnosticLoggingKeys.h
patching file LayoutTests/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file LayoutTests/fast/history/page-cache-webdatabase-opened-db-expected.txt
patching file LayoutTests/fast/history/page-cache-webdatabase-opened-db.html

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Andreas Kling']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.appspot.com/results/5816908611846144

[Chris Dumez]

Created attachment 247525 [details]
Patch

[Chris Dumez]

Comment on attachment 247525 [details]
Patch

Clearing flags on attachment: 247525

Committed r180770: <http://trac.webkit.org/changeset/180770>

[Chris Dumez]

All reviewed patches have been landed.  Closing bug.