Bug 141798 - WebsiteDataStore should ensure that local storage is written before exiting
Summary: WebsiteDataStore should ensure that local storage is written before exiting
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-02-19 10:06 PST by Anders Carlsson
Modified: 2015-02-20 20:51 PST (History)
5 users (show)

See Also:

Attachments
Patch (10.42 KB, patch)
2015-02-19 10:07 PST, Anders Carlsson 		sam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2015-02-19 10:06:16 PST 
WebsiteDataStore should ensure that local storage is written before exiting
Comment 1 Anders Carlsson 2015-02-19 10:07:27 PST 
Created attachment 246895 [details]
Patch
Comment 2 WebKit Commit Bot 2015-02-19 10:09:43 PST 
Attachment 246895 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:56:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Anders Carlsson 2015-02-19 10:46:10 PST 
Committed r180349: <http://trac.webkit.org/changeset/180349>
Comment 4 Csaba Osztrogonác 2015-02-19 11:26:13 PST 
(In reply to comment #3)
> Committed r180349: <http://trac.webkit.org/changeset/180349>

non Cocoa buildfix landed in http://trac.webkit.org/changeset/180350,
I only added empty functions to fix the build, but I have no idea if EFL/GTK
use this code or not, should add platform specific implemenation or not.

Please let us know if we have to do something.