Bug 141722 - [CSS Grid Layout] Remove some leftovers related to "stack" removal
Summary: [CSS Grid Layout] Remove some leftovers related to "stack" removal
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Manuel Rego Casasnovas
URL:
Keywords:
Depends on:
Blocks: 103316
  Show dependency tree / graph
 
Reported: 2015-02-17 13:27 PST by Rego GTK+ EWS Bot
Modified: 2015-02-18 02:29 PST (History)
4 users (show)

See Also:

Attachments
Patch (2.63 KB, patch)
2015-02-17 13:28 PST, Rego GTK+ EWS Bot 		no flags Details | Formatted Diff | Diff
Patch (2.63 KB, patch)
2015-02-17 13:30 PST, Manuel Rego Casasnovas 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rego GTK+ EWS Bot 2015-02-17 13:27:31 PST 
[CSS Grid Layout] Remove some leftovers related to "stack" removal
Comment 1 Rego GTK+ EWS Bot 2015-02-17 13:28:04 PST 
Created attachment 246762 [details]
Patch
Comment 2 Manuel Rego Casasnovas 2015-02-17 13:28:56 PST 
Wrong mail address to upload the patch.
Comment 3 Manuel Rego Casasnovas 2015-02-17 13:30:07 PST 
Reopening to attach new patch.
Comment 4 Manuel Rego Casasnovas 2015-02-17 13:30:11 PST 
Created attachment 246763 [details]
Patch
Comment 5 Sergio Villar Senin 2015-02-18 01:33:31 PST 
Comment on attachment 246763 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=246763&action=review

> LayoutTests/fast/css-grid-layout/grid-auto-flow-resolution.html:-48
> -    <div class="grid smallGrid gridAutoFlowStack" id="gridAutoFlowStack">

Weren't we using the id?
Comment 6 Manuel Rego Casasnovas 2015-02-18 01:44:26 PST 
(In reply to comment #5)
> Comment on attachment 246763 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=246763&action=review
> 
> > LayoutTests/fast/css-grid-layout/grid-auto-flow-resolution.html:-48
> > -    <div class="grid smallGrid gridAutoFlowStack" id="gridAutoFlowStack">
> 
> Weren't we using the id?

Nope, not sure why it was there :-)
Comment 7 WebKit Commit Bot 2015-02-18 02:28:59 PST 
Comment on attachment 246763 [details]
Patch

Clearing flags on attachment: 246763

Committed r180263: <http://trac.webkit.org/changeset/180263>
Comment 8 WebKit Commit Bot 2015-02-18 02:29:03 PST 
All reviewed patches have been landed.  Closing bug.