Bug 141721 - StackLayoutPhase should use CodeBlock::usesArguments rather than FunctionExecutable::usesArguments
Summary: StackLayoutPhase should use CodeBlock::usesArguments rather than FunctionExec...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
: 141246 (view as bug list)
Depends on:
Blocks:
 
Reported: 2015-02-17 13:05 PST by Filip Pizlo
Modified: 2016-08-04 16:26 PDT (History)
1 user (show)

See Also:

Attachments
the patch (2.93 KB, patch)
2015-02-17 13:07 PST, Filip Pizlo 		msaboff: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2015-02-17 13:05:23 PST 
I've seen cases where the two are out of sync.  We know we can trust the CodeBlock::usesArguments because we use it everywhere else.
Comment 1 Filip Pizlo 2015-02-17 13:07:11 PST 
Created attachment 246761 [details]
the patch
Comment 2 Michael Saboff 2015-02-17 13:33:09 PST 
Comment on attachment 246761 [details]
the patch

r=me
Comment 3 Filip Pizlo 2015-02-17 13:41:55 PST 
Landed in http://trac.webkit.org/changeset/180237
Comment 4 Brent Fulgham 2016-08-04 16:26:48 PDT 
*** Bug 141246 has been marked as a duplicate of this bug. ***