The media/video-fullscreeen-only-controls.html layout test is failing since r179612 (http://trac.webkit.org/179612). The diff is the following: --- /home/ch01/wk-tools/layout-test-results/media/video-fullscreeen-only-controls-expected.txt +++ /home/ch01/wk-tools/layout-test-results/media/video-fullscreeen-only-controls-actual.txt @@ -5,9 +5,9 @@ EXPECTED (video.hasAttribute('controls') == 'false') OK EXPECTED (video.controls == 'false') OK EXPECTED (shadowRoot = internals.shadowRoot(video) != 'null') OK -EXPECTED (panel = mediaControlsElement(shadowRoot.firstChild, '-webkit-media-controls-panel') != 'null') OK -EXPECTED (internals.shadowPseudoId(panel) == '-webkit-media-controls-panel') OK -EXPECTED (document.defaultView.getComputedStyle(panel)['display'] != 'none') OK -EXPECTED (document.defaultView.getComputedStyle(panel)['height'] >= '20px') OK +EXPECTED (panel = mediaControlsElement(shadowRoot.firstChild, '-webkit-media-controls-panel') != 'null'), OBSERVED 'null' FAIL +Error: InvalidAccessError: DOM Exception 15 +TypeError: null is not an object (evaluating 'document.defaultView.getComputedStyle(panel)') +TypeError: null is not an object (evaluating 'document.defaultView.getComputedStyle(panel)') END OF TEST
Created attachment 318364 [details] Patch
Comment on attachment 318364 [details] Patch Rejecting attachment 318364 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 318364, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: ilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ... Currently at 220854 = 8e6e489dabeb4975d24b72647ea19cdd0fef400c r220856 = 0c063cae22c2455f7b6ec95789c6fdda397b0be1 r220857 = 4ce2c62a498ac2ae3bae7750af796f0d198609e8 Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Total errors found: 0 in 0 files Full output: http://webkit-queues.webkit.org/results/4330647
Created attachment 318486 [details] Patch
Comment on attachment 318486 [details] Patch Clearing flags on attachment: 318486 Committed r220910: <http://trac.webkit.org/changeset/220910>
All reviewed patches have been landed. Closing bug.
<rdar://problem/33959455>