Bug 141622 – Web Inspector: remove unused XHR replay code

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Brian Burg]

It hasn't been used since the new frontend.

[Radar WebKit Bug Importer]

<rdar://problem/19840911>

[Brian Burg]

Created attachment 246625 [details]
Proposed Fix

[Timothy Hatcher]

Comment on attachment 246625 [details]
Proposed Fix

Nikita and I have been considering adding it to the UI. But I wouldn't want to limit it to XHR.

[Brian Burg]

(In reply to comment #3)
> Comment on attachment 246625 [details]
> Proposed Fix
> 
> Nikita and I have been considering adding it to the UI. But I wouldn't want
> to limit it to XHR.

It's highly likely you want to revisit the design of NetworkResourcesData, it is very crufty and written in the era before NetworkProcess etc. It should be much easier to get and manage loader data now.

[WebKit Commit Bot]

Comment on attachment 246625 [details]
Proposed Fix

Clearing flags on attachment: 246625

Committed r180132: <http://trac.webkit.org/changeset/180132>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Said Abou-Hallawa]

Committed r180133: <http://trac.webkit.org/changeset/180133>

[Brian Burg]

(In reply to comment #7)
> Committed r180133: <http://trac.webkit.org/changeset/180133>

Said, I'm not sure what you intended to do, but you reused this commit's message for something to do with SVG code. Please figure out what's going on, this is the second time I've seen your commits do this.