Bug 141622 - Web Inspector: remove unused XHR replay code
Summary: Web Inspector: remove unused XHR replay code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Brian Burg
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-02-15 11:24 PST by Brian Burg
Modified: 2015-02-25 16:37 PST (History)
10 users (show)

See Also:

Attachments
Proposed Fix (32.75 KB, patch)
2015-02-15 15:28 PST, Brian Burg 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Burg 2015-02-15 11:24:17 PST 
It hasn't been used since the new frontend.
Comment 1 Radar WebKit Bug Importer 2015-02-15 11:24:32 PST 
<rdar://problem/19840911>
Comment 2 Brian Burg 2015-02-15 15:28:17 PST 
Created attachment 246625 [details]
Proposed Fix
Comment 3 Timothy Hatcher 2015-02-15 17:10:22 PST 
Comment on attachment 246625 [details]
Proposed Fix

Nikita and I have been considering adding it to the UI. But I wouldn't want to limit it to XHR.
Comment 4 Brian Burg 2015-02-15 17:31:51 PST 
(In reply to comment #3)
> Comment on attachment 246625 [details]
> Proposed Fix
> 
> Nikita and I have been considering adding it to the UI. But I wouldn't want
> to limit it to XHR.

It's highly likely you want to revisit the design of NetworkResourcesData, it is very crufty and written in the era before NetworkProcess etc. It should be much easier to get and manage loader data now.
Comment 5 WebKit Commit Bot 2015-02-15 18:17:48 PST 
Comment on attachment 246625 [details]
Proposed Fix

Clearing flags on attachment: 246625

Committed r180132: <http://trac.webkit.org/changeset/180132>
Comment 6 WebKit Commit Bot 2015-02-15 18:17:53 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Said Abou-Hallawa 2015-02-15 18:21:49 PST 
Committed r180133: <http://trac.webkit.org/changeset/180133>
Comment 8 Brian Burg 2015-02-15 18:42:47 PST 
(In reply to comment #7)
> Committed r180133: <http://trac.webkit.org/changeset/180133>

Said, I'm not sure what you intended to do, but you reused this commit's message for something to do with SVG code. Please figure out what's going on, this is the second time I've seen your commits do this.