Bug 141617 - [CMAKE] Remove CMakeLists.txt in WK1 port
Summary: [CMAKE] Remove CMakeLists.txt in WK1 port
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-02-14 19:51 PST by Gyuyoung Kim
Modified: 2015-02-17 08:31 PST (History)
2 users (show)

See Also:


Attachments
Patch (6.02 KB, patch)
2015-02-14 19:52 PST, Gyuyoung Kim
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2015-02-14 19:51:08 PST
AFAIK, nobody uses cmake in WK1 port. So let's remove it.
Comment 1 Gyuyoung Kim 2015-02-14 19:52:17 PST
Created attachment 246612 [details]
Patch
Comment 2 Csaba Osztrogonác 2015-02-15 01:08:24 PST
There were some plans to add cmake build system to Apple Mac 
and Windows ports. Maybe they will need it once. Alex, Peavo?

But if they dropped this plan, we could get rid of all these crufts.
Comment 3 Gyuyoung Kim 2015-02-15 01:18:28 PST
(In reply to comment #2)
> There were some plans to add cmake build system to Apple Mac 
> and Windows ports. Maybe they will need it once. Alex, Peavo?

If they have a plan to add cmake build system to their WK1 ports, I will drop this removal.
Comment 4 Gyuyoung Kim 2015-02-15 18:18:35 PST
If there is no feedback till tomorrow, I would like to land this patch. If they need to use this removal, feel free to revert this commit then.
Comment 5 WebKit Commit Bot 2015-02-17 08:31:11 PST
Comment on attachment 246612 [details]
Patch

Clearing flags on attachment: 246612

Committed r180220: <http://trac.webkit.org/changeset/180220>
Comment 6 WebKit Commit Bot 2015-02-17 08:31:16 PST
All reviewed patches have been landed.  Closing bug.