Bug 141561 - Add some RELEASE_ASSERTs to try to catch crashes in StyleResolver::loadPendingImages
Summary: Add some RELEASE_ASSERTs to try to catch crashes in StyleResolver::loadPendin...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-02-13 07:10 PST by Antti Koivisto
Modified: 2015-02-24 04:51 PST (History)
2 users (show)

See Also:

Attachments
patch (3.82 KB, patch)
2015-02-13 07:17 PST, Antti Koivisto 		simon.fraser: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2015-02-13 07:10:50 PST 
One possibility is that loads triggered by loadPendingImages end up synchronously destroying or re-entering style resolver. Add some asserts.
Comment 1 Antti Koivisto 2015-02-13 07:17:42 PST 
Created attachment 246522 [details]
patch
Comment 2 Antti Koivisto 2015-02-13 09:33:04 PST 
https://trac.webkit.org/r180051
Comment 3 Chris Dumez 2015-02-13 09:47:04 PST 
Which radar / crash is that?
Comment 5 Antti Koivisto 2015-02-24 04:51:44 PST 
Made this actually work in https://trac.webkit.org/r180554