RESOLVED FIXED141513
[buildbot] Remove buildJSCTool cruft from master.cfg
https://bugs.webkit.org/show_bug.cgi?id=141513
Summary [buildbot] Remove buildJSCTool cruft from master.cfg
Csaba Osztrogonác
Reported 2015-02-12 09:02:13 PST
buildJSCTool was to determine if the run-javascriptcore-tests and run-webkit-tests should build JSC/DRT/WTR or not. These scripts call build-jsc / build-dumprendertree if --no-build isn't passed. Let's see run-javascriptore-tests first. Now master.cfg passes --no-build for all bots, except EFL/GTK "build and tester" bots, where calling build-jsc is unnecessary, because JSC is already built by build-webkit previously. Let's see run-webkit-tests. buildJSCTool is true on non Windows bots and --no-build is explicitly passed to Mac and Win bots unconditionally, but not for EFL/GTK bots when build-dumprendertree/build-webkittestrunner don't do anything useful on EFL and GTK, just simple return 0. So let's remove this huge and misleading cruft and pass --no-build everywhere unconditionally.
Attachments
Patch (5.40 KB, patch)
2015-02-12 09:03 PST, Csaba Osztrogonác
no flags
Csaba Osztrogonác
Comment 1 2015-02-12 09:03:47 PST
Csaba Osztrogonác
Comment 2 2015-02-13 06:37:17 PST
Comment on attachment 246445 [details] Patch Clearing flags on attachment: 246445 Committed r180039: <http://trac.webkit.org/changeset/180039>
Csaba Osztrogonác
Comment 3 2015-02-13 06:37:25 PST
All reviewed patches have been landed. Closing bug.
Csaba Osztrogonác
Comment 4 2015-02-13 09:50:28 PST
Ryosuke or Lucas, could you apply this change on the master if you have a little bit of free time? Thanks.
Lucas Forschler
Comment 5 2015-02-13 09:55:06 PST
done
Csaba Osztrogonác
Comment 6 2015-02-13 10:02:08 PST
(In reply to comment #5) > done yay, the bots already picked it up and they are a little bit faster now. :)
Note You need to log in before you can comment on or make changes to this bug.