Bug 141505 - Simplify the initialization of BytecodeGenerator a bit
Summary: Simplify the initialization of BytecodeGenerator a bit
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-02-11 23:32 PST by Benjamin Poulain
Modified: 2015-02-12 14:20 PST (History)
2 users (show)

See Also:

Attachments
Patch (8.96 KB, patch)
2015-02-11 23:35 PST, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews104 for mac-mavericks-wk2 (739.53 KB, application/zip)
2015-02-12 00:02 PST, Build Bot 		no flags Details
Patch (8.90 KB, patch)
2015-02-12 00:11 PST, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2015-02-11 23:32:59 PST 
Simplify the initialization of BytecodeGenerator a bit
Comment 1 Benjamin Poulain 2015-02-11 23:35:58 PST 
Created attachment 246433 [details]
Patch
Comment 2 Build Bot 2015-02-12 00:02:50 PST 
Comment on attachment 246433 [details]
Patch

Attachment 246433 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/4898614706962432

New failing tests:
js/dfg-convert-this-dom-window.html
js/function-call-aliased.html
js/function-apply-aliased.html
Comment 3 Build Bot 2015-02-12 00:02:54 PST 
Created attachment 246436 [details]
Archive of layout-test-results from ews104 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5
Comment 4 Benjamin Poulain 2015-02-12 00:04:41 PST 
Comment on attachment 246433 [details]
Patch

Ooops, I am a dumbass.
Comment 5 Benjamin Poulain 2015-02-12 00:11:21 PST 
Created attachment 246438 [details]
Patch
Comment 6 Anders Carlsson 2015-02-12 07:19:53 PST 
Comment on attachment 246438 [details]
Patch

Very nice!
Comment 7 Benjamin Poulain 2015-02-12 14:20:27 PST 
Comment on attachment 246438 [details]
Patch

Clearing flags on attachment: 246438

Committed r180012: <http://trac.webkit.org/changeset/180012>
Comment 8 Benjamin Poulain 2015-02-12 14:20:53 PST 
All reviewed patches have been landed.  Closing bug.