Bug 141457 - REGRESSION (iOS 8): PDFs embedded in <object>/<embed> tag don't load at all
Summary: REGRESSION (iOS 8): PDFs embedded in <object>/<embed> tag don't load at all
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-02-10 19:06 PST by Tim Horton
Modified: 2015-02-11 13:36 PST (History)
3 users (show)

See Also:


Attachments
Patch (1.68 KB, patch)
2015-02-10 19:06 PST, Tim Horton
no flags Details | Formatted Diff | Diff
Patch (5.03 KB, patch)
2015-02-11 13:26 PST, Tim Horton
ap: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2015-02-10 19:06:18 PST
[iOS] WebKit2 should render <object> and <embed> PDFs with PDFDocumentImage
Comment 1 Tim Horton 2015-02-10 19:06:33 PST
Created attachment 246368 [details]
Patch
Comment 2 Tim Horton 2015-02-10 19:06:58 PST
<rdar://problem/18221851>
Comment 3 mitz 2015-02-10 19:14:46 PST
A better title for this bug might be “REGRESSION (iOS 8): PDFs embedded in <object>/<embed> tag don't load at all”
Comment 4 mitz 2015-02-10 19:20:05 PST
This can have a reftest with <img> on the -expected side, right?
Comment 5 Tim Horton 2015-02-10 19:26:17 PST
Seems reasonable.
Comment 6 Tim Horton 2015-02-11 13:26:00 PST
Created attachment 246409 [details]
Patch
Comment 7 Alexey Proskuryakov 2015-02-11 13:28:30 PST
Comment on attachment 246409 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=246409&action=review

> LayoutTests/TestExpectations:482
> +# The current expectations for this test only make sense for WebKit on iOS; other platforms can have very different behaviors.
> +fast/replaced/pdf-as-object-and-embed.html [ Skip ]

The test makes sense on all platforms though, so seems like it should be enabled, with different expectations elsewhere.
Comment 8 Tim Horton 2015-02-11 13:33:57 PST
(In reply to comment #7)
> Comment on attachment 246409 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=246409&action=review
> 
> > LayoutTests/TestExpectations:482
> > +# The current expectations for this test only make sense for WebKit on iOS; other platforms can have very different behaviors.
> > +fast/replaced/pdf-as-object-and-embed.html [ Skip ]
> 
> The test makes sense on all platforms though, so seems like it should be
> enabled, with different expectations elsewhere.

I filed https://bugs.webkit.org/show_bug.cgi?id=141488.
Comment 9 Tim Horton 2015-02-11 13:36:59 PST
http://trac.webkit.org/changeset/179955