Bug 141336 - Ref-ify various getters that return HTMLCollection.
Summary: Ref-ify various getters that return HTMLCollection.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-02-06 13:25 PST by Andreas Kling
Modified: 2015-02-06 17:09 PST (History)
1 user (show)

See Also:

Attachments
Patch (26.34 KB, patch)
2015-02-06 13:25 PST, Andreas Kling 		no flags Details | Formatted Diff | Diff
Patch (26.93 KB, patch)
2015-02-06 15:41 PST, Andreas Kling 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2015-02-06 13:25:00 PST 
We have a lot of getters that return non-null RefPtr<HTMLCollection> that should just return Ref<HTMLCollection>.
Comment 1 Andreas Kling 2015-02-06 13:25:29 PST 
Created attachment 246177 [details]
Patch
Comment 2 WebKit Commit Bot 2015-02-06 13:27:11 PST 
Attachment 246177 [details] did not pass style-queue:


ERROR: Source/WebCore/html/HTMLTableSectionElement.cpp:63:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 1 in 30 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Andreas Kling 2015-02-06 15:41:43 PST 
Created attachment 246183 [details]
Patch
Comment 4 WebKit Commit Bot 2015-02-06 17:08:59 PST 
Comment on attachment 246183 [details]
Patch

Clearing flags on attachment: 246183

Committed r179770: <http://trac.webkit.org/changeset/179770>
Comment 5 WebKit Commit Bot 2015-02-06 17:09:03 PST 
All reviewed patches have been landed.  Closing bug.