Bug 141171 - VirtualRegister should really know how to dump itself
Summary: VirtualRegister should really know how to dump itself
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks: 141174
  Show dependency treegraph
 
Reported: 2015-02-02 14:26 PST by Filip Pizlo
Modified: 2015-02-02 15:33 PST (History)
10 users (show)

See Also:


Attachments
the patch (28.83 KB, patch)
2015-02-02 14:40 PST, Filip Pizlo
ggaren: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2015-02-02 14:26:42 PST
Currently it dumps itself as an int, which isn't very useful.  We then end up with a lot of scattered code for dumping VirtualRegister.
Comment 1 Filip Pizlo 2015-02-02 14:40:41 PST
Created attachment 245902 [details]
the patch
Comment 2 Geoffrey Garen 2015-02-02 14:41:35 PST
Comment on attachment 245902 [details]
the patch

r=me
Comment 3 Filip Pizlo 2015-02-02 15:33:56 PST
Landed in http://trac.webkit.org/changeset/179503