Bug 141129 - Shrink RenderBlock.
Summary: Shrink RenderBlock.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords: Performance
: 141128 (view as bug list)
Depends on:
Blocks:
 
Reported: 2015-01-31 16:44 PST by Andreas Kling
Modified: 2015-02-01 16:15 PST (History)
6 users (show)

See Also:


Attachments
Patch (15.71 KB, patch)
2015-01-31 16:45 PST, Andreas Kling
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2015-01-31 16:44:13 PST
Looks like we can lose the line-height cache in RenderBlock without affecting any benchmarks, then the remaining bits fit into RenderElement's bitfield.
Savings potential: 8 bytes per RenderBlock (including subclasses)
Comment 1 Andreas Kling 2015-01-31 16:45:05 PST
Created attachment 245805 [details]
Patch
Comment 2 WebKit Commit Bot 2015-01-31 18:58:10 PST
Comment on attachment 245805 [details]
Patch

Clearing flags on attachment: 245805

Committed r179454: <http://trac.webkit.org/changeset/179454>
Comment 3 WebKit Commit Bot 2015-01-31 18:58:13 PST
All reviewed patches have been landed.  Closing bug.
Comment 4 Alexey Proskuryakov 2015-02-01 16:15:11 PST
*** Bug 141128 has been marked as a duplicate of this bug. ***