Bug 141101 - Merge SimpleFontDataIOS.mm and SimpleFontDataMac.mm into FontCocoa.mm
Summary: Merge SimpleFontDataIOS.mm and SimpleFontDataMac.mm into FontCocoa.mm
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-01-30 15:44 PST by Sam Weinig
Modified: 2015-01-31 12:42 PST (History)
2 users (show)

See Also:


Attachments
Patch (74.84 KB, patch)
2015-01-30 15:53 PST, Sam Weinig
no flags Details | Formatted Diff | Diff
Patch (79.32 KB, patch)
2015-01-30 16:20 PST, Sam Weinig
no flags Details | Formatted Diff | Diff
Patch (79.67 KB, patch)
2015-01-30 16:44 PST, Sam Weinig
no flags Details | Formatted Diff | Diff
Patch (79.70 KB, patch)
2015-01-30 16:57 PST, Sam Weinig
mitz: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2015-01-30 15:44:43 PST
Merge SimpleFontDataIOS.mm and SimpleFontDataMac.mm into FontCocoa.mm
Comment 1 Sam Weinig 2015-01-30 15:53:16 PST
Created attachment 245750 [details]
Patch
Comment 2 WebKit Commit Bot 2015-01-30 15:56:05 PST
Attachment 245750 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/cocoa/FontCocoa.mm:136:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/graphics/cocoa/FontCocoa.mm:296:  Missing spaces around /  [whitespace/operators] [3]
ERROR: Source/WebCore/platform/graphics/cocoa/FontCocoa.mm:396:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
ERROR: Source/WebCore/platform/graphics/cocoa/FontCocoa.mm:397:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
ERROR: Source/WebCore/platform/graphics/cocoa/FontCocoa.mm:397:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/platform/graphics/cocoa/FontCocoa.mm:398:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
ERROR: Source/WebCore/platform/graphics/cocoa/FontCocoa.mm:398:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/platform/graphics/cocoa/FontCocoa.mm:399:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 8 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Sam Weinig 2015-01-30 16:20:38 PST
Created attachment 245753 [details]
Patch
Comment 4 Sam Weinig 2015-01-30 16:44:45 PST
Created attachment 245758 [details]
Patch
Comment 5 WebKit Commit Bot 2015-01-30 16:46:16 PST
Attachment 245758 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/cocoa/FontCocoa.mm:128:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/graphics/cocoa/FontCocoa.mm:287:  Missing spaces around /  [whitespace/operators] [3]
Total errors found: 2 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Sam Weinig 2015-01-30 16:57:49 PST
Created attachment 245762 [details]
Patch
Comment 7 WebKit Commit Bot 2015-01-30 17:00:22 PST
Attachment 245762 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/cocoa/FontCocoa.mm:128:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/graphics/cocoa/FontCocoa.mm:287:  Missing spaces around /  [whitespace/operators] [3]
Total errors found: 2 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 8 mitz 2015-01-31 12:41:57 PST
Comment on attachment 245762 [details]
Patch

rs=me
Comment 9 Sam Weinig 2015-01-31 12:42:52 PST
Committed r179445: <http://trac.webkit.org/changeset/179445>