Bug 141052 - Remove more Mountain Lion code from WebKit2
Summary: Remove more Mountain Lion code from WebKit2
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-01-29 14:56 PST by Beth Dakin
Modified: 2015-01-29 15:20 PST (History)
6 users (show)

See Also:

Attachments
Patch (33.36 KB, patch)
2015-01-29 14:59 PST, Beth Dakin 		thorton: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Beth Dakin 2015-01-29 14:56:37 PST 
Remove more Mountain Lion code from WebKit2
Comment 1 Beth Dakin 2015-01-29 14:59:36 PST 
Created attachment 245655 [details]
Patch
Comment 2 Tim Horton 2015-01-29 15:08:20 PST 
Comment on attachment 245655 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=245655&action=review

> Source/WebKit2/config.h:-73
> -#if PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 1090

Shouldn't this still be in a PLATFORM(MAC)?

> Source/WebKit2/Shared/WebPreferencesDefinitions.h:-41
> -#if PLATFORM(IOS) || (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 1090)

Sam conflicted with you here.

> Source/WebKit2/WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:-173
> -#if !PLATFORM(IOS) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 1090

swap this to PLATFORM(MAC)?
Comment 3 Beth Dakin 2015-01-29 15:20:39 PST 
(In reply to comment #2)
> Comment on attachment 245655 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=245655&action=review
> 
> > Source/WebKit2/config.h:-73
> > -#if PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 1090
> 
> Shouldn't this still be in a PLATFORM(MAC)?
> 

YES! Good catch.

> > Source/WebKit2/Shared/WebPreferencesDefinitions.h:-41
> > -#if PLATFORM(IOS) || (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 1090)
> 
> Sam conflicted with you here.
> 

Resolved now.

> > Source/WebKit2/WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:-173
> > -#if !PLATFORM(IOS) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 1090
> 
> swap this to PLATFORM(MAC)?

Sure. As we discussed on IRC, there are a lot of these, and they suck. But sure, I will fix this one.

http://trac.webkit.org/changeset/179373