Bug 141005 – Simple line layout: Drop uncommitted/committed terms from LineState.

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[alan]

and replace it with segments and runs. Multiple fragments form a segment and they turn into runs.
(uncommitted/committed terms a bit confusing. We only add fragments that we know that fit the line.)

[alan]

Created attachment 245562 [details]
Patch

[Antti Koivisto]

Comment on attachment 245562 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=245562&action=review

> Source/WebCore/rendering/SimpleLineLayout.cpp:286
> +    bool firstCharacterFits() const
> +    {
> +        return m_firstCharacterFits;
> +    }

This could be on a single line.

[alan]

Created attachment 245567 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 245567 [details]
Patch

Rejecting attachment 245567 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 245567, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
d at 317 with fuzz 2 (offset 1 line).
Hunk #4 succeeded at 331 (offset 1 line).
Hunk #5 FAILED at 399.
Hunk #6 succeeded at 423 with fuzz 1 (offset 1 line).
Hunk #7 FAILED at 438.
Hunk #8 FAILED at 447.
Hunk #9 FAILED at 462.
Hunk #10 FAILED at 482.
Hunk #11 FAILED at 536.
8 out of 11 hunks FAILED -- saving rejects to file Source/WebCore/rendering/SimpleLineLayout.cpp.rej

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.appspot.com/results/6041009704140800

[alan]

Created attachment 245569 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 245569 [details]
Patch

Clearing flags on attachment: 245569

Committed r179309: <http://trac.webkit.org/changeset/179309>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.