Bug 140973 – Web Inspector: Crash closing inspected page with frequent activity

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Joseph Pecoraro]

Created attachment 245500 [details]
[ARCHIVE] Test Archive

* SUMMARY
WebContent crash closing inspected page with frequent activity.

* STEPS
1. Open the_mind_of_a_con_man.webarchive
2. Show Reader
3. Inspect Reader page (⌥⌘C)
4. Hide Reader
  => CRASH (repeat 3-4 if not crash)

* NOTES
- Crashes can be anywhere under WebPage::close(), when any Dispatcher attempts to use the InspectorFrontendChannel (WebInspector object that was just destroyed in WebPage::close without disconnecting).

* CRASH 1

    Exception Type:        EXC_BAD_ACCESS (SIGSEGV)
    Exception Codes:       KERN_INVALID_ADDRESS at 0x0000000000013647

    Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
    0   com.apple.JavaScriptCore      	0x00007fff83be0235 Inspector::InspectorNetworkFrontendDispatcher::loadingFailed(WTF::String const&, double, WTF::String const&, bool const*) + 1077
    1   com.apple.WebCore             	0x00007fff844bdedf WebCore::InspectorResourceAgent::didFailLoading(unsigned long, WebCore::DocumentLoader*, WebCore::ResourceError const&) + 431
    2   com.apple.WebCore             	0x00007fff83f8ff7c WebCore::InspectorInstrumentation::didFailLoadingImpl(WebCore::InstrumentingAgents*, unsigned long, WebCore::DocumentLoader*, WebCore::ResourceError const&) + 76
    3   com.apple.WebCore             	0x00007fff83fd9cca WebCore::ResourceLoader::cancel(WebCore::ResourceError const&) + 426
    4   com.apple.WebCore             	0x00007fff83fd9b06 WebCore::ResourceLoader::cancel() + 70
    5   com.apple.WebCore             	0x00007fff84279098 WebCore::cancelAll(WTF::HashMap<unsigned long, WTF::RefPtr<WebCore::ResourceLoader>, WTF::IntHash<unsigned long>, WTF::HashTraits<unsigned long>, WTF::HashTraits<WTF::RefPtr<WebCore::ResourceLoader> > > const&) + 296
    6   com.apple.WebCore             	0x00007fff83e48ad1 WebCore::DocumentLoader::stopLoading() + 1361
    7   com.apple.WebCore             	0x00007fff83e484d0 WebCore::FrameLoader::stopAllLoaders(WebCore::ClearProvisionalItemPolicy) + 208
    8   com.apple.WebCore             	0x00007fff83efa85a WebCore::FrameLoader::detachFromParent() + 122
    9   com.apple.WebCore             	0x00007fff83ddabf5 WebCore::FrameLoader::detachChildren() + 245
    10  com.apple.WebCore             	0x00007fff83efa850 WebCore::FrameLoader::detachFromParent() + 112
    11  com.apple.WebKit              	0x00007fff9250d7f7 WebKit::WebPage::close() + 751
    ...


* CRASH 2

    Exception Type:        EXC_BAD_ACCESS (SIGSEGV)
    Exception Codes:       KERN_INVALID_ADDRESS at 0x0000000000000010

    Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
    0   com.apple.JavaScriptCore      	0x00000001118b2eba Inspector::InspectorPageFrontendDispatcher::frameDetached(WTF::String const&) + 346
    1   com.apple.WebCore             	0x0000000114026856 WebCore::InspectorPageAgent::frameDetached(WebCore::Frame&) + 230 (InspectorPageAgent.cpp:735)
    2   com.apple.WebCore             	0x0000000113ffa928 WebCore::InspectorInstrumentation::frameDetachedFromParentImpl(WebCore::InstrumentingAgents&, WebCore::Frame&) + 56 (InspectorInstrumentation.cpp:747)
    3   com.apple.WebCore             	0x0000000113b9bfc4 WebCore::InspectorInstrumentation::frameDetachedFromParent(WebCore::Frame&) + 52 (InspectorInstrumentation.h:1029)
    4   com.apple.WebCore             	0x0000000113b8dead WebCore::FrameLoader::detachFromParent() + 157 (FrameLoader.cpp:2492)
    5   com.apple.WebCore             	0x0000000113b876f3 WebCore::FrameLoader::detachChildren() + 275 (FrameLoader.cpp:2409)
    6   com.apple.WebCore             	0x0000000113b8de8d WebCore::FrameLoader::detachFromParent() + 125 (FrameLoader.cpp:2484)
    7   com.apple.WebCore             	0x0000000113b876f3 WebCore::FrameLoader::detachChildren() + 275 (FrameLoader.cpp:2409)
    8   com.apple.WebCore             	0x0000000113b8de8d WebCore::FrameLoader::detachFromParent() + 125 (FrameLoader.cpp:2484)
    9   com.apple.WebCore             	0x0000000113b876f3 WebCore::FrameLoader::detachChildren() + 275 (FrameLoader.cpp:2409)
    10  com.apple.WebCore             	0x0000000113b8de8d WebCore::FrameLoader::detachFromParent() + 125 (FrameLoader.cpp:2484)
    11  com.apple.WebCore             	0x0000000113b876f3 WebCore::FrameLoader::detachChildren() + 275 (FrameLoader.cpp:2409)
    12  com.apple.WebCore             	0x0000000113b8de8d WebCore::FrameLoader::detachFromParent() + 125 (FrameLoader.cpp:2484)
    13  com.apple.WebKit              	0x000000010ebc6f54 WebKit::WebPage::close() + 3364 (WebPage.cpp:1031)
    ...

[Joseph Pecoraro]

<rdar://problem/15833013>

[Joseph Pecoraro]

Created attachment 245502 [details]
[PATCH] Proposed Fix

[Timothy Hatcher]

Comment on attachment 245502 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=245502&action=review

> Source/WebKit2/WebProcess/WebPage/WebInspector.h:90
> +    virtual ~WebInspector() { close(); }

Usually we add a method like webPageDestroyed() and call it from ~WebPage. Just because the WebPage is destroyed doesn't mean it was he last reference for WebInspector.

[Timothy Hatcher]

Comment on attachment 245502 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=245502&action=review

>> Source/WebKit2/WebProcess/WebPage/WebInspector.h:90
>> +    virtual ~WebInspector() { close(); }
> 
> Usually we add a method like webPageDestroyed() and call it from ~WebPage. Just because the WebPage is destroyed doesn't mean it was he last reference for WebInspector.

Which you would call in WebPage::close, so it should cakes somthing like webPageClosed.

[Joseph Pecoraro]

Created attachment 245561 [details]
[PATCH] Proposed Fix

[WebKit Commit Bot]

Comment on attachment 245561 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 245561

Committed r179321: <http://trac.webkit.org/changeset/179321>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.