Bug 140902 - Rename Document::body() to Document::bodyOrFrameset() for clarity
Summary: Rename Document::body() to Document::bodyOrFrameset() for clarity
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL: http://www.w3.org/TR/html5/dom.html#d...
Keywords:
Depends on:
Blocks:
 
Reported: 2015-01-26 14:09 PST by Chris Dumez
Modified: 2015-01-26 16:26 PST (History)
4 users (show)

See Also:

Attachments
Patch (38.79 KB, patch)
2015-01-26 14:45 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (39.60 KB, patch)
2015-01-26 15:13 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2015-01-26 14:09:58 PST 
Rename Document::body() to Document::bodyOrFrameset() for clarity. This method does not necessarily return an HTMLBodyElement, it can also return a frameset as per the specification:
http://www.w3.org/TR/html5/dom.html#dom-tree-accessors

This method is often misused internally (the caller is only interested in the <body> element). I will fix these instances in a follow-up patch.
Comment 1 Chris Dumez 2015-01-26 14:45:31 PST 
Created attachment 245377 [details]
Patch
Comment 2 Chris Dumez 2015-01-26 15:13:21 PST 
Created attachment 245380 [details]
Patch
Comment 3 Andreas Kling 2015-01-26 15:38:38 PST 
Comment on attachment 245380 [details]
Patch

r=me
Comment 4 WebKit Commit Bot 2015-01-26 16:26:24 PST 
Comment on attachment 245380 [details]
Patch

Clearing flags on attachment: 245380

Committed r179157: <http://trac.webkit.org/changeset/179157>
Comment 5 WebKit Commit Bot 2015-01-26 16:26:30 PST 
All reviewed patches have been landed.  Closing bug.