Bug 140885 - [cmake] Remove compiler version calculate cruft
Summary: [cmake] Remove compiler version calculate cruft
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Csaba Osztrogonác
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-01-26 05:34 PST by Csaba Osztrogonác
Modified: 2015-01-26 10:04 PST (History)
2 users (show)

See Also:

Attachments
Patch (1.62 KB, patch)
2015-01-26 05:35 PST, Csaba Osztrogonác 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2015-01-26 05:34:01 PST 
[cmake] Remove compiler version calculate cruft
Comment 1 Csaba Osztrogonác 2015-01-26 05:35:15 PST 
Created attachment 245343 [details]
Patch

It depends on bug140884, which fixes the grammar issue of TestWithFailureCount.
Comment 2 Csaba Osztrogonác 2015-01-26 05:38:23 PST 
(In reply to comment #1)
> Created attachment 245343 [details]
> Patch

This COMPILER_VERSION variable isn't used long long time ago, not to 
mention the non-dumpversion case, which is a QNX cruft introduced in http://trac.webkit.org/changeset/105014/trunk/Source/cmake/WebKitHelpers.cmake

Let's remove this cruft.

> It depends on bug140884, which fixes the grammar issue of
> TestWithFailureCount.
Ooops, this comment is a copy/paste error, please ignore it.
Comment 3 WebKit Commit Bot 2015-01-26 10:04:01 PST 
Comment on attachment 245343 [details]
Patch

Clearing flags on attachment: 245343

Committed r179121: <http://trac.webkit.org/changeset/179121>
Comment 4 WebKit Commit Bot 2015-01-26 10:04:07 PST 
All reviewed patches have been landed.  Closing bug.