WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
140885
[cmake] Remove compiler version calculate cruft
https://bugs.webkit.org/show_bug.cgi?id=140885
Summary
[cmake] Remove compiler version calculate cruft
Csaba Osztrogonác
Reported
2015-01-26 05:34:01 PST
[cmake] Remove compiler version calculate cruft
Attachments
Patch
(1.62 KB, patch)
2015-01-26 05:35 PST
,
Csaba Osztrogonác
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1
2015-01-26 05:35:15 PST
Created
attachment 245343
[details]
Patch It depends on
bug140884
, which fixes the grammar issue of TestWithFailureCount.
Csaba Osztrogonác
Comment 2
2015-01-26 05:38:23 PST
(In reply to
comment #1
)
> Created
attachment 245343
[details]
> Patch
This COMPILER_VERSION variable isn't used long long time ago, not to mention the non-dumpversion case, which is a QNX cruft introduced in
http://trac.webkit.org/changeset/105014/trunk/Source/cmake/WebKitHelpers.cmake
Let's remove this cruft.
> It depends on
bug140884
, which fixes the grammar issue of > TestWithFailureCount.
Ooops, this comment is a copy/paste error, please ignore it.
WebKit Commit Bot
Comment 3
2015-01-26 10:04:01 PST
Comment on
attachment 245343
[details]
Patch Clearing flags on attachment: 245343 Committed
r179121
: <
http://trac.webkit.org/changeset/179121
>
WebKit Commit Bot
Comment 4
2015-01-26 10:04:07 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug