Bug 140884 - [buildbot] Fix grammar of TestWithFailureCount
Summary: [buildbot] Fix grammar of TestWithFailureCount
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Csaba Osztrogonác
URL:
Keywords:
Depends on:
Blocks: 140821
  Show dependency tree / graph
 
Reported: 2015-01-26 04:24 PST by Csaba Osztrogonác
Modified: 2015-01-26 09:20 PST (History)
5 users (show)

See Also:

Attachments
Patch (6.48 KB, patch)
2015-01-26 04:29 PST, Csaba Osztrogonác 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2015-01-26 04:24:29 PST 
class TestWithFailureCount(shell.Test):
    failedTestsFormatString = "%d tests failed"

output is always in plural, which is incorrect and should be fixed.
Comment 1 Csaba Osztrogonác 2015-01-26 04:29:03 PST 
Created attachment 245340 [details]
Patch
Comment 2 Csaba Osztrogonác 2015-01-26 04:30:11 PST 
the idea is come from: https://bugs.webkit.org/show_bug.cgi?id=140821#c4 :
"1 tests" is not good grammar. Given that one failing test is the most common failure case, I think that the error text should be nice.
Comment 3 WebKit Commit Bot 2015-01-26 04:31:03 PST 
Attachment 245340 [details] did not pass style-queue:


ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:158:  [RunLLINTCLoopTestsTest.test_failure] Undefined variable 'FAILURE'  [pylint/E0602] [5]
ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:179:  [Run32bitJSCTestsTest.test_failure] Undefined variable 'FAILURE'  [pylint/E0602] [5]
Total errors found: 2 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Csaba Osztrogonác 2015-01-26 09:20:24 PST 
Comment on attachment 245340 [details]
Patch

Clearing flags on attachment: 245340

Committed r179116: <http://trac.webkit.org/changeset/179116>
Comment 5 Csaba Osztrogonác 2015-01-26 09:20:33 PST 
All reviewed patches have been landed.  Closing bug.