Bug 140876 - security/mixedContent/redirect-https-to-http-iframe-in-main-frame test is the same as security/mixedContent/redirect-http-to-https-iframe-in-main-frame.html
Summary: security/mixedContent/redirect-https-to-http-iframe-in-main-frame test is the...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Minor
Assignee: Michael Catanzaro
URL:
Keywords:
Depends on:
Blocks: 140625
  Show dependency treegraph
 
Reported: 2015-01-25 17:16 PST by Michael Catanzaro
Modified: 2015-01-28 23:00 PST (History)
4 users (show)

See Also:


Attachments
patch (3.13 KB, patch)
2015-01-25 17:24 PST, Michael Catanzaro
no flags Details | Formatted Diff | Diff
Patch (3.40 KB, patch)
2015-01-27 09:24 PST, Michael Catanzaro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2015-01-25 17:16:17 PST
This looks like a copypaste error. security/mixedContent/redirect-https-to-http-iframe-in-main-frame.html is identical to security/mixedContent/redirect-http-to-https-iframe-in-main-frame.html because it loads https://127.0.0.1:8443/security/mixedContent/resources/frame-with-redirect-http-to-https-frame.html. It should be loading https://127.0.0.1:8443/security/mixedContent/resources/frame-with-redirect-https-to-http-frame.html.
Comment 1 Michael Catanzaro 2015-01-25 17:24:39 PST
Created attachment 245319 [details]
patch

This one is an easy review.
Comment 2 Darin Adler 2015-01-25 20:07:54 PST
Comment on attachment 245319 [details]
patch

Not sure why the patch doen’t apply, but EWS says it doesn’t. Could you upload a new one?
Comment 3 Michael Catanzaro 2015-01-27 09:17:03 PST
Oops, the test expectations depend on bug #140621. I will remove the dependency from this patch, and then update the patch in that bug once this one lands.
Comment 4 Michael Catanzaro 2015-01-27 09:24:40 PST
Created attachment 245450 [details]
Patch
Comment 5 WebKit Commit Bot 2015-01-28 23:00:39 PST
Comment on attachment 245450 [details]
Patch

Clearing flags on attachment: 245450

Committed r179336: <http://trac.webkit.org/changeset/179336>
Comment 6 WebKit Commit Bot 2015-01-28 23:00:54 PST
All reviewed patches have been landed.  Closing bug.