Bug 140860 - [iOS] [SVG -> OTF Converter] Flip the switch off on iOS
Summary: [iOS] [SVG -> OTF Converter] Flip the switch off on iOS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-01-24 19:34 PST by Myles C. Maxfield
Modified: 2015-01-26 10:33 PST (History)
8 users (show)

See Also:

Attachments
Patch (31.22 KB, patch)
2015-01-24 19:36 PST, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (6.79 KB, patch)
2015-01-26 08:43 PST, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2015-01-24 19:34:16 PST 
[iOS] [SVG -> OTF Converter] Flip the switch off on iOS
Comment 1 Myles C. Maxfield 2015-01-24 19:36:54 PST 
Created attachment 245291 [details]
Patch
Comment 2 Myles C. Maxfield 2015-01-24 19:38:40 PST 
<rdar://problem/19571385>
Comment 3 Tim Horton 2015-01-24 19:59:28 PST 
Comment on attachment 245291 [details]
Patch

In the interests of minimizing this patch, why not just keep it in the xcconfig file and switch by platform (see earlier examples, like ENABLE_WEB_TIMING)?
Comment 4 Myles C. Maxfield 2015-01-24 20:00:30 PST 
Because xcconfig files are ugly. (4 different places to say the same thing???)
Comment 5 Sam Weinig 2015-01-24 23:15:04 PST 
Comment on attachment 245291 [details]
Patch

This change should be in the xcconfig file only. There is no reason to use Platform.h for this.
Comment 6 Myles C. Maxfield 2015-01-26 08:43:42 PST 
Created attachment 245351 [details]
Patch
Comment 7 WebKit Commit Bot 2015-01-26 10:33:33 PST 
Comment on attachment 245351 [details]
Patch

Clearing flags on attachment: 245351

Committed r179124: <http://trac.webkit.org/changeset/179124>
Comment 8 WebKit Commit Bot 2015-01-26 10:33:38 PST 
All reviewed patches have been landed.  Closing bug.